Changeset 503 for trunk/kernel

Timestamp:

Aug 25, 2018, 6:28:18 PM (6 years ago)

Author:

viala@…

Message:

Add void type on function that takes no parameters, fix invalid call.

Fix invalid calls to thread_can_yield.

In file included from kern/chdev.c:29:
kern/chdev.c: In function 'chdev_sequencial_server':
kern/chdev.c:329:21: error: too many arguments to function 'thread_can_yield'

assert( thread_can_yield( server ) , "illegal sched_yield\n" );

^~

Also fixed signature of mapper_create.

Location:

trunk/kernel

Files:

• devices/dev_pic.h (modified) (1 diff)
• kern/chdev.c (modified) (1 diff)
• kern/do_syscall.c (modified) (1 diff)
• kern/process.c (modified) (1 diff)
• kern/process.h (modified) (1 diff)
• kern/rpc.c (modified) (2 diffs)
• kern/rpc.h (modified) (1 diff)
• kern/thread.c (modified) (1 diff)
• kern/thread.h (modified) (1 diff)
• mm/mapper.h (modified) (1 diff)
• mm/vseg.c (modified) (1 diff)
• mm/vseg.h (modified) (1 diff)

trunk/kernel/devices/dev_pic.h

@@ -84 +84 @@
  ****************************************************************************************/
 
-typedef void   (bind_irq_t)     ( lid_t lid , struct chdev_s * src_chdev );   
-typedef void   (enable_irq_t)   ( lid_t lid , xptr_t src_chdev_xp );   
-typedef void   (disable_irq_t)  ( lid_t lid , xptr_t src_chdev_xp );   
-typedef void   (enable_timer_t) ( uint32_t period );   
-typedef void   (enable_ipi_t)   ( );   
-typedef void   (send_ipi_t)     ( cxy_t cxy , lid_t lid ); 
-typedef void   (ack_ipi_t)      ( );   
-typedef void   (extend_init_t)  ( uint32_t * lapic_base ); 
+typedef void   (bind_irq_t)     ( lid_t lid , struct chdev_s * src_chdev );
+typedef void   (enable_irq_t)   ( lid_t lid , xptr_t src_chdev_xp );
+typedef void   (disable_irq_t)  ( lid_t lid , xptr_t src_chdev_xp );
+typedef void   (enable_timer_t) ( uint32_t period );
+typedef void   (enable_ipi_t)   ( void );
+typedef void   (send_ipi_t)     ( cxy_t cxy , lid_t lid );
+typedef void   (ack_ipi_t)      ( void );
+typedef void   (extend_init_t)  ( uint32_t * lapic_base );
   
 typedef struct pic_extend_s

trunk/kernel/kern/chdev.c

@@ -264 +264 @@
 
     // deschedule
-    assert( thread_can_yield( this ) , "illegal sched_yield\n" );
+    assert( thread_can_yield() , "illegal sched_yield\n" );
     sched_yield("blocked on I/O");
 

trunk/kernel/kern/do_syscall.c

@@ -34 +34 @@
 // This ƒonction should never be called...
 ///////////////////////////////////////////////////////////////////////////////////////
-static int sys_undefined()
+static int sys_undefined( void )
 {
     assert( false , "undefined system call" );

trunk/kernel/kern/process.c

@@ -65 +65 @@
 
 ///////////////////////////
-process_t * process_alloc()
+process_t * process_alloc( void )
 {
         kmem_req_t   req;

trunk/kernel/kern/process.h

@@ -176 +176 @@
  * @ returns pointer on process descriptor if success / return NULL if failure
  ********************************************************************************************/
-process_t * process_alloc();
+process_t * process_alloc( void );
 
 /*********************************************************************************************

trunk/kernel/kern/rpc.c

@@ -83 +83 @@
 
 //////////////////////////////////////////////
-void __attribute__((noinline)) rpc_undefined()
+void __attribute__((noinline)) rpc_undefined( xptr_t xp __attribute__ ((unused)) )
 {
         assert( false , "called in cluster %x", local_cxy );
@@ -459 +459 @@
 
             // RPC thread deschedules
-            assert( thread_can_yield( server_ptr ) , "illegal sched_yield\n" );
+            assert( thread_can_yield() , "illegal sched_yield\n" );
             sched_yield("RPC fifo empty");
         }

trunk/kernel/kern/rpc.h

@@ -176 +176 @@
  * This function is executed in case of illegal RPC index.
  **********************************************************************************/
-void __attribute__((noinline)) rpc_undefined();
+void __attribute__((noinline)) rpc_undefined( xptr_t xp __attribute__ ((unused)) );
 
 

trunk/kernel/kern/thread.c

@@ -889 +889 @@
 
 ////////////////////////////////
-inline bool_t thread_can_yield()
+inline bool_t thread_can_yield( void )
 {
     thread_t * this = CURRENT_THREAD;

trunk/kernel/kern/thread.h

@@ -369 +369 @@
  * @ returns true if no locks taken.
  **************************************************************************************/
-inline bool_t thread_can_yield();
+inline bool_t thread_can_yield( void );
 
 /***************************************************************************************

trunk/kernel/mm/mapper.h

@@ -105 +105 @@
  * @ return pointer on created mapper if success / return NULL if no memory
  ******************************************************************************************/
-mapper_t * mapper_create();
+mapper_t * mapper_create( void );
 
 /*******************************************************************************************

trunk/kernel/mm/vseg.c

@@ -60 +60 @@
 
 /////////////////////
-vseg_t * vseg_alloc()
+vseg_t * vseg_alloc( void )
 {
     kmem_req_t   req;

trunk/kernel/mm/vseg.h

@@ -102 +102 @@
  * @ return pointer on allocated vseg descriptor if success / return NULL if failure.
  ******************************************************************************************/
-vseg_t * vseg_alloc();
+vseg_t * vseg_alloc( void );
 
 /*******************************************************************************************