Changeset 505

Timestamp:

Aug 25, 2018, 6:28:53 PM (6 years ago)

Author:

viala@…

Message:

[hal] Fix protoypes and add headers in hal mips32 implementation.

Fix types mismatch between implementation and interface in .h.
Add header where they were absent.

Location:

trunk/hal

Files:

• generic/hal_atomic.h (modified) (1 diff)
• tsar_mips32/core/hal_atomic.c (modified) (4 diffs)
• tsar_mips32/core/hal_exception.c (modified) (1 diff)
• tsar_mips32/core/hal_user.c (modified) (1 diff)

trunk/hal/generic/hal_atomic.h

@@ -63 +63 @@
  * @ return shared variable value before add
  ****************************************************************************************/
-uint32_t hal_atomic_add( void     * ptr,
-                         int32_t    val );
+int32_t hal_atomic_add( void     * ptr,
+                        int32_t    val );
 
 /*****************************************************************************************

trunk/hal/tsar_mips32/core/hal_atomic.c

@@ -23 +23 @@
 
 #include <hal_kernel_types.h>
+#include <hal_atomic.h>
 
 ////////////////////////////////////
 void hal_atomic_and( uint32_t * ptr,
-                     int32_t    val )
+                     uint32_t   val )
 {
         asm volatile (
@@ -43 +44 @@
 ///////////////////////////////////
 void hal_atomic_or( uint32_t * ptr,
-                    int32_t    val )
+                    uint32_t   val )
 {
         asm volatile (
@@ -59 +60 @@
 
 ///////////////////////////////////////
-uint32_t hal_atomic_add( void    * ptr,
-                         int32_t   val )
+int32_t hal_atomic_add( void     * ptr,
+                        int32_t   val )
 {
         int32_t current;
@@ -106 +107 @@
 ///////////////////////////////////////////
 bool_t hal_atomic_test_set( uint32_t * ptr,
-                            int32_t    val )
+                            uint32_t   val )
 {
         return hal_atomic_cas( ptr , 0 , val );

trunk/hal/tsar_mips32/core/hal_exception.c

@@ -38 +38 @@
 #include <hal_kentry.h>
 
+#include <hal_exception.h>
 
 //////////////////////////////////////////////////////////////////////////////////////////

trunk/hal/tsar_mips32/core/hal_user.c

@@ -22 +22 @@
  */
 
+#include <hal_user.h>
 
 /////////////////////////////////////////////
-inline int hal_user_syscall( int service_num,
-                             int arg0,
-                             int arg1,
-                             int arg2,
-                             int arg3 )
+inline int hal_user_syscall( reg_t service_num,
+                             reg_t arg0,
+                             reg_t arg1,
+                             reg_t arg2,
+                             reg_t arg3 )
 {
     register int num_and_ret __asm__("v0") = service_num;