Changeset 636 for trunk/kernel/libk

Timestamp:

Jul 1, 2019, 9:34:16 AM (5 years ago)

Author:

alain

Message:

Fix a bug in list_remote_add_first() and list_remote_add_last() functions,
used by the physical memory allocator, that corrupted the PPM state.

Location:

trunk/kernel/libk

Files:

• list.h (modified) (5 diffs)
• xlist.h (modified) (1 diff)

trunk/kernel/libk/list.h

@@ -3 +3 @@
  *
  * Authors Ghassan Almaless  (2008,2009,2010,2011,2012)
- *         Alain Greiner     (2016,2017,2018i,2019)
+ *         Alain Greiner     (2016,2017,2018,2019)
  *
  * Copyright (c) UPMC Sorbonne Universites
@@ -314 +314 @@
  * item(s) from the traversed list.     
  ***************************************************************************
- * @ cxy     : remote cluster identifier
- * @ root    : pointer on the root list_entry
- * @ iter    : pointer on the current list_entry
- **************************************************************************/
-
-#define LIST_REMOTE_FOREACH( cxy , root , iter )               \
-for( (iter) = hal_remote_lpt( XPTR( cxy , &(root)->next ) ) ;  \
-     (iter) != (root) ;                         \
-     (iter) = hal_remote_lpt( XPTR( cxy , &(iter)->next ) ) ) 
+ * @ cxy     : remote cluster identifier.
+ * @ root    : pointer on the root list_entry.
+ * @ iter    : pointer on the current list_entry.
+ **************************************************************************/
+
+#define LIST_REMOTE_FOREACH( cxy , root , iter )                 \
+for( (iter) = hal_remote_lpt( XPTR( (cxy) , &(root)->next ) ) ;  \
+     (iter) != (root) ;                                                      \
+     (iter) = hal_remote_lpt( XPTR( (cxy) , &(iter)->next ) ) ) 
         
+/***************************************************************************
+ * This macro can be used by a thread running in any cluster to access
+ * a remote local list. It traverse the list in backward order.
+ * WARNING : same as the forward traversal
+ ***************************************************************************
+ * @ cxy       : remote cluster identifier.
+ * @ root      : pointer on the root list_entry.
+ * @ iter      : pointer on the current list_entry.
+ **************************************************************************/
+
+#define LIST_REMOTE_FOREACH_BACKWARD( cxy , root , iter )       \
+for( (iter) = hal_remote_lpt( XPTR( (cxy) , &(root)->pred ) ) ; \
+     (iter) != (root) ;                                         \
+     (iter) = hal_remote_lpt( XPTR( (cxy) , &(iter)->pred ) ) )
+
 /***************************************************************************
  * This function can be called by a thread running in any cluster to access
@@ -350 +365 @@
                                           list_entry_t * entry )
 {
-    list_entry_t * first;    // local pointer on current first entry
-    list_entry_t * next;     // local pointer on current first->next entry
-  
-        first  = hal_remote_lpt( XPTR( cxy , &root->next ) );
-    next   = hal_remote_lpt( XPTR( cxy , &first->next ) );
+    list_entry_t * next = hal_remote_lpt( XPTR( cxy , &root->next ) );
         
-        hal_remote_spt( XPTR( cxy , &entry->next ) , first );
+        hal_remote_spt( XPTR( cxy , &entry->next ) , next );
         hal_remote_spt( XPTR( cxy , &entry->pred ) , root );
   
@@ -375 +386 @@
                                          list_entry_t * entry )
 {
-    list_entry_t * last;     // local pointer on current last entry
-    list_entry_t * pred;     // local pointer on current last->pred entry
-  
-        last   = hal_remote_lpt( XPTR( cxy , &root->pred ) );
-    pred   = hal_remote_lpt( XPTR( cxy , &last->pred ) );
+    list_entry_t * pred = hal_remote_lpt( XPTR( cxy , &root->pred ) );
         
         hal_remote_spt( XPTR( cxy , &entry->next ) , root );
@@ -409 +416 @@
 
 
-
 #endif  /* _LIST_H_ */

trunk/kernel/libk/xlist.h

@@ -1 +1 @@
 /*
-    // check calling thread can yield
-    thread_assert_can_yield( this , __FUNCTION__ );
-
  * xlist.h - Double Circular Linked lists, using extended pointers.
  *
- * Author : Alain Greiner (2016,2017,2018)
+ * Author : Alain Greiner (2016,2017,2018,2019)
  *
  * Copyright (c) UPMC Sorbonne Universites