Changeset 303

Timestamp:

Feb 26, 2013, 4:19:54 PM (12 years ago)

Author:

joannou

Message:

Bug fix in generic_cache_tsar component :
In the read_select function,

• Added an _set variable uset instead of the argument for inner tests.
• Initialized found argument to false, and use it for inner tests.
• Removed the if(!found) tests.

File:

• trunk/lib/generic_cache_tsar/include/generic_cache.h (modified) (2 diffs)

trunk/lib/generic_cache_tsar/include/generic_cache.h

@@ -600 +600 @@
                             bool*     cleanup )
     {
+        size_t _set = m_y[ad];
+
+        *found = false;
+
         // Search first empty slot 
-        for ( size_t _way = 0 ; _way < m_ways && !found ; _way++ )
-        {
-            if ( cache_state(_way, *set) == CACHE_SLOT_STATE_EMPTY )
+        for ( size_t _way = 0 ; _way < m_ways && !(*found) ; _way++ )
+        {
+            if ( cache_state(_way, _set) == CACHE_SLOT_STATE_EMPTY )
             {
                 *found   = true;
@@ -613 +617 @@
         }
         // Search first not zombi old slot 
-        if ( !found )
-        { 
-            for ( size_t _way = 0 ; _way < m_ways && !found ; _way++ )
-            {
-                if ( not cache_lru(_way, *set) and 
-                     (cache_state(_way, *set) != CACHE_SLOT_STATE_ZOMBI) )
-                {
-                    *found   = true;
-                    *cleanup = true;
-                    *way     = _way;
-                    *set     = m_y[ad];
-                    *victim  = (addr_t)((cache_tag(*way,*set) * m_sets) + *set);
-                    return;
-                }
+        for ( size_t _way = 0 ; _way < m_ways && !(*found) ; _way++ )
+        {
+            if ( not cache_lru(_way, _set) and 
+                 (cache_state(_way, _set) != CACHE_SLOT_STATE_ZOMBI) )
+            {
+                *found   = true;
+                *cleanup = true;
+                *way     = _way;
+                *set     = m_y[ad];
+                *victim  = (addr_t)((cache_tag(*way,_set) * m_sets) + _set);
+                return;
             }
         }
         // Search first not zombi slot
-        if ( !found )
-        { 
-            for ( size_t _way = 0 ; _way < m_ways && !found ; _way++ )
-            {
-                if ( cache_state(_way, *set) != CACHE_SLOT_STATE_ZOMBI) 
-                {
-                    *found   = true;
-                    *cleanup = true;
-                    *way    = _way;
-                    *set     = m_y[ad];
-                    *victim  = (addr_t)((cache_tag(*way,*set) * m_sets) + *set);
-                    return;
-                }
+        for ( size_t _way = 0 ; _way < m_ways && !(*found) ; _way++ )
+        {
+            if ( cache_state(_way, _set) != CACHE_SLOT_STATE_ZOMBI) 
+            {
+                *found   = true;
+                *cleanup = true;
+                *way    = _way;
+                *set     = m_y[ad];
+                *victim  = (addr_t)((cache_tag(*way,_set) * m_sets) + _set);
+                return;
             }
         }