Changeset 279 for trunk/hal/tsar_mips32/core/hal_remote.c

Timestamp:

Jul 27, 2017, 12:23:29 AM (7 years ago)

Author:

alain

Message:

1) Introduce independant command fields for the various devices in the thread descriptor.
2) Introduce a new dev_pic_enable_ipi() function in the generic PIC device
3) Fix two bugs identified by Maxime in the scheduler initialisation, and in the sched_select().
4) fix several bugs in the TSAR hal_kentry.S.
5) Introduce a third kgiet segment (besides kdata and kcode) in the TSAR bootloader.

File:

• trunk/hal/tsar_mips32/core/hal_remote.c (modified) (1 diff)

trunk/hal/tsar_mips32/core/hal_remote.c

@@ -34 +34 @@
     uint32_t cxy = (uint32_t)GET_CXY( xp );
 
-    hal_disable_irq( &save_sr );
-
-    asm volatile( 
-        ".set noreorder              \n"
-        "mfc2   $15,    $24          \n"  /* $15 <= PADDR_EXT */   
-        "mtc2   %2,     $24          \n"  /* PADDR_EXT <= cxy */   
-        "sb     %0,     0(%1)        \n"  /* *paddr <= value  */
-        "mtc2   $15,    $24          \n"  /* PADDR_EXT <= $15 */   
+/* TODO improve all hal remote functions to include SR handling in assembly code */
+/* as it is done below for hal_remote_sb                                         */
+
+    asm volatile( 
+        ".set noreorder              \n"
+        "mfc0   $14,    $12          \n"  /* $14 <= CP0_SR      */
+        "srl    $13,    $14,    1    \n" 
+        "sll    $13,    $13,    1    \n"  /* $13 <= SR masked   */
+        "mtc0   $13,    $12          \n"  /* IRQ disabled       */
+        
+
+        "mfc2   $15,    $24          \n"  /* $15 <= PADDR_EXT   */   
+        "mtc2   %2,     $24          \n"  /* PADDR_EXT <= cxy   */   
+        "sb     %0,     0(%1)        \n"  /* *paddr <= value    */
+        "mtc2   $15,    $24          \n"  /* PADDR_EXT <= $15   */   
+
+        "mtc0   $14,    $12          \n"  /* SR restored        */
+
         "sync                        \n"
         ".set reorder                \n"
-        : : "r" (data), "r" (ptr), "r" (cxy) : "$15" );
-
-    hal_restore_irq( save_sr );
-
+        : : "r" (data), "r" (ptr), "r" (cxy) : "$13", "$14", "$15" );
 }