Changeset 451 for trunk/hal/tsar_mips32/drivers/soclib_pic.h

Timestamp:

Jul 5, 2018, 3:45:43 PM (6 years ago)

Author:

alain

Message:

Fix a bug in soclib_pic driver (bad separation between IOPIC an LAPIC initialisation)

File:

• trunk/hal/tsar_mips32/drivers/soclib_pic.h (modified) (3 diffs)

trunk/hal/tsar_mips32/drivers/soclib_pic.h

@@ -25 +25 @@
 #define _SOCLIB_PIC_H_
 
-#include <hal_types.h>
+#include <hal_kernel_types.h>
 
 /****  Forward declarations  ****/
@@ -167 +167 @@
 
 /******************************************************************************************
- * This blocking function disables all input IRQs in the IOPIC controller, and
- * disables all HWIs, WTIs, and PTIs in the XCU (LAPIC) controllers, for all cores,
- * in all clusters.
+ * This function disables all input IRQs in the external IOPIC controller. 
  * It must be called by a thread running in the cluster containing the PIC chdev. 
 ******************************************************************************************
@@ -177 +175 @@
 
 /*****************************************************************************************
- * This function allocates memory from local cluster for the SOCLIB PIC core extensions
+ * This function allocates memory from local cluster for the local PIC core extensions
  * of all cores contained in the cluster, initializes the two HWI, WTI interrupt vectors
  * as empty, and registers - for each core - the pointer in core descriptor.
- * Then it allocates memory from local cluster for the SOCLIB PIC cluster extension,
- * to implement the XCU WTI allocator, and registers the pointer in cluster manager.
- * It access the local XCU component to get actual number of HWI / WTI / PTI. 
+ * Then it allocates memory from local cluster for the PIC cluster extension,
+ * and registers the pointer in cluster manager.
+ * It accesses the local XCU component to get actual number of HWI / WTI / PTI. 
+ * Finally, it disables all HWI/WTI/PTI interrupts for all cores by writing in the
+ * relevant mask registers of the local XCU component.
  *****************************************************************************************
  * @ xcu_base  : local pointer on XCU controller segment base.