Changeset 506 for trunk/kernel/syscalls/sys_thread_create.c

Timestamp:

Aug 25, 2018, 6:29:34 PM (6 years ago)

Author:

viala@…

Message:

[syscalls] add interface in implementation.

Add const where possible, fix protoypes to follow interface.

File:

• trunk/kernel/syscalls/sys_thread_create.c (modified) (8 diffs)

trunk/kernel/syscalls/sys_thread_create.c

@@ -39 +39 @@
 #include <rpc.h>
 
+#include <syscalls.h>
 
 ///////////////////////////////////////////////////
-int sys_thread_create ( pthread_t      * trdid_ptr,
-                        pthread_attr_t * user_attr,
-                        void           * start_func,
-                        void           * start_arg )
+int sys_thread_create(
+  struct thread_s             * new_thread,
+  const struct pthread_attr_s * user_attr,
+  const void                  * start_func,
+  const void                  * start_args )
 {
         pthread_attr_t   kern_attr;        // copy of pthread attributes in kernel space
@@ -72 +74 @@
 
     // check trdid buffer in user space
-    error = vmm_get_vseg( process , (intptr_t)trdid_ptr , &vseg );
+    error = vmm_get_vseg( process , (intptr_t)new_thread , &vseg );
 
     if ( error )
@@ -79 +81 @@
 #if DEBUG_SYSCALLS_ERROR
 printk("\n[ERROR] in %s : trdid buffer unmapped %x / thread %x / process %x\n",
-__FUNCTION__ , (intptr_t)trdid_ptr, parent->trdid, process->pid );
+__FUNCTION__ , (intptr_t)new_thread, parent->trdid, process->pid );
 vmm_display( process , false );
 #endif
@@ -121 +123 @@
         }
 
-        // check start_arg buffer in user space
-        if( start_arg != NULL )
-    {
-        error = vmm_get_vseg( process , (intptr_t)start_arg , &vseg );
+        // check start_args buffer in user space
+        if( start_args != NULL )
+    {
+        error = vmm_get_vseg( process , (intptr_t)start_args , &vseg );
 
             if( error )
@@ -130 +132 @@
 
 #if DEBUG_SYSCALLS_ERROR
-printk("\n[ERROR] in %s : start_arg buffer unmapped %x / thread %x / process %x\n",
-__FUNCTION__ , (intptr_t)start_arg , parent->trdid , process->pid );
+printk("\n[ERROR] in %s : start_args buffer unmapped %x / thread %x / process %x\n",
+__FUNCTION__ , (intptr_t)start_args , parent->trdid , process->pid );
 vmm_display( process , false );
 #endif
@@ -176 +178 @@
                 error = thread_user_create( process->pid,
                                             start_func,
-                                            start_arg,
+                                            start_args,
                                             &kern_attr,
                                             &child_ptr );
@@ -187 +189 @@
                                                process->pid,
                                                start_func,
-                                               start_arg,
+                                               start_args,
                                                &kern_attr,
                                                &child_xp,
@@ -209 +211 @@
         // returns trdid to user space
         trdid = hal_remote_lw( XPTR( target_cxy , &child_ptr->trdid ) );
-        hal_copy_to_uspace( trdid_ptr , &trdid , sizeof(pthread_t) );
+        hal_copy_to_uspace( new_thread , &trdid , sizeof(pthread_t) );
 
     // activate new thread