Changeset 514 for trunk/kernel/kern/process.c

Timestamp:

Aug 26, 2018, 7:24:25 PM (6 years ago)

Author:

viala@…

Message:

[process] fix undefined/declared variable in process_register_thread.

We made a typo.

Found with GCC:

kern/process.c: In function 'process_register_thread':
kern/process.c:1054:7: warning: 'type' may be used uninitialized in this function [-Wmaybe-uninitialized]

if( type == THREAD_IDLE ) spinlock_lock_busy( &process->th_lock , &save_sr );

File:

• trunk/kernel/kern/process.c (modified) (3 diffs)

trunk/kernel/kern/process.c

@@ -1041 +1041 @@
 {
     ltid_t         ltid;
-    thread_type_t  type;
     reg_t          save_sr;
     bool_t         found = false;
@@ -1052 +1051 @@
     // take lock protecting th_tbl, depending on thread type:
     // we don't want to use a descheduling policy for idle thread initialisation
-    if( type == THREAD_IDLE )  spinlock_lock_busy( &process->th_lock , &save_sr );
-    else                       spinlock_lock( &process->th_lock );
+    if ( thread->type == THREAD_IDLE ) {
+        spinlock_lock_busy( &process->th_lock , &save_sr );
+    } else {
+        spinlock_lock( &process->th_lock );
+    }
 
     // search a free slot in th_tbl[] 
@@ -1077 +1079 @@
     // release lock protecting th_tbl
     hal_fence();
-    if( type == THREAD_IDLE )  spinlock_unlock_busy( &process->th_lock , save_sr );
-    else                       spinlock_unlock( &process->th_lock );
+    if( thread->type == THREAD_IDLE ) {
+        spinlock_unlock_busy( &process->th_lock , save_sr );
+    } else {
+        spinlock_unlock( &process->th_lock );
+    }
 
     return (found) ? 0 : ENOMEM;