Changeset 527 for trunk/kernel/fs/vfs.c

Timestamp:

Aug 30, 2018, 10:26:27 PM (6 years ago)

Author:

viala@…

Message:

Rewrite if-then-else return function into switch case.

For safety reason and performance:

1) Safety: GCC complain with a warning if you forgot an enum variant.
2) code-gen just outperform naive if-then-else.

File:

• trunk/kernel/fs/vfs.c (modified) (1 diff)

trunk/kernel/fs/vfs.c

@@ -127 +127 @@
 //////////////////////////////////////////////////////////////////////////////////////////
 
-char * vfs_inode_type_str( uint32_t type )
-{
-    if     ( type == INODE_TYPE_FILE ) return "FILE";
-    else if( type == INODE_TYPE_DIR  ) return "DIR ";
-    else if( type == INODE_TYPE_FIFO ) return "FIFO";
-    else if( type == INODE_TYPE_PIPE ) return "PIPE";
-    else if( type == INODE_TYPE_SOCK ) return "SOCK";
-    else if( type == INODE_TYPE_DEV  ) return "DEV ";
-    else if( type == INODE_TYPE_SYML ) return "SYML";
-    else                               return "undefined";
+static const char * vfs_inode_type_str( vfs_inode_type_t type )
+{
+    switch ( type ) {
+    case INODE_TYPE_FILE: return "FILE";
+    case INODE_TYPE_DIR:  return "DIR ";
+    case INODE_TYPE_FIFO: return "FIFO";
+    case INODE_TYPE_PIPE: return "PIPE";
+    case INODE_TYPE_SOCK: return "SOCK";
+    case INODE_TYPE_DEV:  return "DEV ";
+    case INODE_TYPE_SYML: return "SYML";
+    default:              return "undefined";
+    }
 }