Changeset 629 for trunk/hal/tsar_mips32/core/hal_vmm.c

Timestamp:

May 17, 2019, 9:27:04 AM (5 years ago)

Author:

alain

Message:

Remove the "giant" rwlock protecting the GPT, and
use the GPT_LOCKED attribute in each PTE to prevent
concurrent modifications of one GPT entry.
The version number has been incremented to 2.1.

File:

• trunk/hal/tsar_mips32/core/hal_vmm.c (modified) (5 diffs)

trunk/hal/tsar_mips32/core/hal_vmm.c

@@ -81 +81 @@
     uint32_t ppn  = cxy << 20;    
 
-    // register PTE1  in slot[0] of kernel GPT
-    error = hal_gpt_set_pte( XPTR( cxy , gpt ) , 0 , attr , ppn );
-
-    if( error )
-    {
-        printk("\n[PANIC] in %s : cannot initialize kernel GPT in cluster %x\n",
-        __FUNCTION__ , cxy );
-        hal_core_sleep();
-    }
+    // set PT1[0]
+    hal_gpt_set_pte( XPTR( cxy , gpt ) , 0 , attr , ppn );
 
 #if DEBUG_HAL_VMM
@@ -159 +152 @@
 
     // update user GPT : set PTE1 in slot[0]
-    error = hal_gpt_set_pte( u_gpt_xp , 0 , attr , ppn );
-
-    if( error )
-    {
-        printk("\n[ERROR] in %s : cannot update user GPT in cluster %x\n",
-        __FUNCTION__ , cxy );
-        return -1;
-    }
+    hal_gpt_set_pte( u_gpt_xp , 0 , attr , ppn );
 
 #if DEBUG_HAL_VMM
@@ -220 +206 @@
     chdev_t * txt0_ptr = GET_PTR( txt0_xp );
 
-    // build extended pointers on TXT0 lock, GPT lock and VSL lock
+    // build extended pointer on TXT0 lock and VSL lock
     xptr_t  txt_lock_xp = XPTR( txt0_cxy  , &txt0_ptr->wait_lock );
     xptr_t  vsl_lock_xp = XPTR( local_cxy , &vmm->vsl_lock );
-    xptr_t  gpt_lock_xp = XPTR( local_cxy , &vmm->gpt_lock );
 
     // get root of vsegs list
@@ -230 +215 @@
     // get the locks protecting TXT0, VSL, and GPT
     remote_rwlock_rd_acquire( vsl_lock_xp );
-    remote_rwlock_rd_acquire( gpt_lock_xp );
     remote_busylock_acquire( txt_lock_xp );
 
@@ -291 +275 @@
     // release locks
     remote_busylock_release( txt_lock_xp );
-    remote_rwlock_rd_release( gpt_lock_xp );
     remote_rwlock_rd_release( vsl_lock_xp );