Changeset 345 for soft/giet_vm/giet_drivers/xcu_driver.c

Timestamp:

Jun 25, 2014, 2:19:37 PM (10 years ago)

Author:

cfuguet

Message:

giet_vm optimizations:

• Several modifications in GIET_VM in order to support compilation with GCC optimizations (-O2) activated.

• Adding missing volatile in some global variables.

• Using ioread and iowrite utility functions in peripheral drivers which prevent GCC to remove writes or reads in hardware memory mapped registers.

• Code refactoring of stdio printf functions. Now, shr_printf and tty_printf function reuse the same function body. The only difference is that shr_printf wraps printf function call with TTY get lock and release lock.

File:

• soft/giet_vm/giet_drivers/xcu_driver.c (modified) (12 diffs)

soft/giet_vm/giet_drivers/xcu_driver.c

@@ -16 +16 @@
 #include <mapping_info.h>
 #include <utils.h>
+#include <io.h>
 
 #if !defined(X_SIZE) 
@@ -49 +50 @@
 #endif
 
+///////////////////////////////////////////////////////////////////////////////
+// This low level function returns the value contained in register "index"
+// in the XCU component contained in cluster "cluster_xy"
+///////////////////////////////////////////////////////////////////////////////
+static
+unsigned int _xcu_get_register( unsigned int cluster_xy, // cluster index
+                                unsigned int func,       // function index
+                                unsigned int index )     // register index
+{
+    unsigned int vaddr =
+        SEG_XCU_BASE + 
+        (cluster_xy * PERI_CLUSTER_INCREMENT) +
+        (XCU_REG(func, index) << 2);
+
+    return ioread32( (void*)vaddr );
+}
+
+///////////////////////////////////////////////////////////////////////////////
+// This low level function sets a new value in register "index"
+// in the XCU component contained in cluster "cluster_xy"
+///////////////////////////////////////////////////////////////////////////////
+static
+void _xcu_set_register( unsigned int cluster_xy,       // cluster index
+                        unsigned int func,             // func index
+                        unsigned int index,            // register index
+                        unsigned int value )           // value to be written
+{
+    unsigned int vaddr =
+        SEG_XCU_BASE + 
+        (cluster_xy * PERI_CLUSTER_INCREMENT) +
+        (XCU_REG(func, index) << 2);
+        
+    iowrite32( (void*)vaddr, value );
+}
 
 ////////////////////////////////////////////////////////////////////////////////
@@ -68 +103 @@
     if (channel >= (NB_PROCS_MAX * IRQ_PER_PROCESSOR)) _exit(); 
 
-    unsigned int* xcu_address = (unsigned int *) ( SEG_XCU_BASE +
-                                (cluster_xy * PERI_CLUSTER_INCREMENT) );
-
-    unsigned int func;
+    unsigned int func = 0;
     if      (irq_type == IRQ_TYPE_PTI) func = XCU_MSK_PTI_ENABLE;
     else if (irq_type == IRQ_TYPE_WTI) func = XCU_MSK_WTI_ENABLE;
@@ -81 +113 @@
     }
 
-    xcu_address[XCU_REG(func,channel)] = value;
+    _xcu_set_register(cluster_xy, func, channel, value);
 
 #else
@@ -110 +142 @@
     if (channel >= (NB_PROCS_MAX * IRQ_PER_PROCESSOR)) _exit(); 
 
-    unsigned int* xcu_address = (unsigned int *) ( SEG_XCU_BASE +
-                                (cluster_xy * PERI_CLUSTER_INCREMENT) );
-
-    unsigned int prio = xcu_address[XCU_REG(XCU_PRIO,channel)];
+    unsigned int prio = _xcu_get_register(cluster_xy, XCU_PRIO, channel);
     unsigned int pti_ok = (prio & 0x00000001);
     unsigned int hwi_ok = (prio & 0x00000002);
@@ -162 +191 @@
     if (wti_index >= 32)           _exit(); 
 
-    unsigned int* xcu_address = (unsigned int *) ( SEG_XCU_BASE +
-                                (cluster_xy * PERI_CLUSTER_INCREMENT) );
-
-    xcu_address[XCU_REG(XCU_WTI_REG,wti_index)] = wdata;
+    _xcu_set_register(cluster_xy, XCU_WTI_REG, wti_index, wdata);
 
 #else
@@ -191 +217 @@
     if (wti_index >= 32)           _exit(); 
  
-    unsigned int* xcu_address = (unsigned int *) ( SEG_XCU_BASE +
-                                (cluster_xy * PERI_CLUSTER_INCREMENT) );
-
-    *value = xcu_address[XCU_REG(XCU_WTI_REG, wti_index)]; 
+    *value = _xcu_get_register(cluster_xy, XCU_WTI_REG, wti_index);
 
 #else
@@ -215 +238 @@
     if (wti_index >= 32)           _exit(); 
  
-    unsigned int xcu_address = (unsigned int)SEG_XCU_BASE;
-    *address = xcu_address + (XCU_REG(XCU_WTI_REG, wti_index)<<2); 
+    *address = SEG_XCU_BASE + (XCU_REG(XCU_WTI_REG, wti_index)<<2); 
 
 #else
@@ -239 +261 @@
     if (y >= Y_SIZE)             _exit(); 
 
-    unsigned int* xcu_address = (unsigned int *) ( SEG_XCU_BASE +
-                                (cluster_xy * PERI_CLUSTER_INCREMENT) );
-
-    xcu_address[XCU_REG(XCU_PTI_PER, pti_index)] = period;
+    _xcu_set_register(cluster_xy, XCU_PTI_PER, pti_index, period);
 
 #else
@@ -264 +283 @@
     if (y >= Y_SIZE)             _exit(); 
 
-    unsigned int* xcu_address = (unsigned int *) ( SEG_XCU_BASE +
-                                (cluster_xy * PERI_CLUSTER_INCREMENT) );
-
-    xcu_address[XCU_REG(XCU_PTI_PER, pti_index)] = 0;
+    _xcu_set_register(cluster_xy, XCU_PTI_PER, pti_index, 0);
 
 #else
@@ -291 +307 @@
     if (y >= Y_SIZE)             _exit(); 
 
-    unsigned int* xcu_address = (unsigned int *) ( SEG_XCU_BASE +
-                                (cluster_xy * PERI_CLUSTER_INCREMENT) );
-
     // This return value is not used / avoid a compilation warning.
-    return xcu_address[XCU_REG(XCU_PTI_ACK, pti_index)];
+    return _xcu_get_register(cluster_xy, XCU_PTI_ACK, pti_index);
 
 #else
@@ -322 +335 @@
     if (y >= Y_SIZE)             _exit(); 
 
-    unsigned int* xcu_address = (unsigned int *) ( SEG_XCU_BASE +
-                                (cluster_xy * PERI_CLUSTER_INCREMENT) );
-
-    unsigned int period = xcu_address[XCU_REG(XCU_PTI_PER, pti_index)];
+    unsigned int per = _xcu_get_register(cluster_xy, XCU_PTI_PER, pti_index);
 
     // we write 0 first because if the timer is currently running, 
     // the corresponding timer counter is not reset
-    xcu_address[XCU_REG(XCU_PTI_PER, pti_index)] = 0;
-    xcu_address[XCU_REG(XCU_PTI_PER, pti_index)] = period;
+    _xcu_set_register(cluster_xy, XCU_PTI_PER, pti_index, 0);
+    _xcu_set_register(cluster_xy, XCU_PTI_PER, pti_index, per);
 
 #else